Renesas TSIP: skip XMEMCPY on MEMORY_E from tsip_StoreMessage()#10705
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the Renesas TSIP TLS 1.3 handshake message buffering path by preventing message data from being copied into MsgBag after capacity/sanity checks have already failed (returning MEMORY_E). This avoids potential out-of-bounds writes/corruption in tsip_StoreMessage().
Changes:
- Wraps the
XMEMCPY()and relatedMsgBagindex updates in anelseblock so they only execute when capacity checks pass. - Ensures the message bag is not mutated when
retis set toMEMORY_E.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JacobBarthelmeh
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the Renesas TSIP port's
tsip_StoreMessage()to skip callingXMEMCPYwhen buffer sanity checks have failed.Fixes item 9 from ZD 21992.
Checklist